Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Primitives v7.12.0 #2207

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Bump Primitives v7.12.0 #2207

merged 5 commits into from
Aug 15, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Aug 14, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Not sure why there are a ton of snapshot changes, if you check em' there's no visual diff 🤷

  • Bump to latest Primitives version
  • Update link tokens to new name
  • Bring back inset tokens where necessary

Integration

We'll need to bump the Primitives version to the latest in the release branch as well.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@langermank langermank requested a review from a team as a code owner August 14, 2023 17:50
@langermank langermank requested review from a team, simurai and keithamus August 14, 2023 17:50
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 6cc2dcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Aug 14, 2023
@langermank langermank temporarily deployed to preview August 14, 2023 17:53 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank temporarily deployed to preview August 14, 2023 19:31 — with GitHub Actions Inactive
@langermank langermank merged commit ba01f4e into main Aug 15, 2023
27 checks passed
@langermank langermank deleted the bump-primitives-7.11.14 branch August 15, 2023 17:22
@primer primer bot mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants