Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable validation messages on radio button and check box groups #2241

Merged
merged 13 commits into from
Sep 14, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Sep 12, 2023

What are you trying to accomplish?

This PR enables validation messages on check box and radio button groups.

Screenshots

Radio button group Check box group
Screenshot of a form with three unselected radio buttons. A prompt at the top asks, 'How did you hear about us?' The radio buttons are labeled 'Online advertisement', 'Radio advertisement', and 'From a friend'. A red validation message appears beneath the radio buttons saying 'Please choose one.' Screenshot of a form with three unselected check boxes. A prompt at the top asks, 'I like to eat, eat, eat'. The check boxes are labeled 'Ey-ples and ba-naynays', 'Eye-ples and ba-nainais', and 'Oh-ples and ba-nonos'. A red validation message appears beneath the check boxes saying 'Please select at least one.'

Integration

No changes necessary in production.

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/2488

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

🦋 Changeset detected

Latest commit: fade3e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to preview September 12, 2023 23:00 — with GitHub Actions Inactive
@github-actions github-actions bot added ruby Pull requests that update Ruby code minor release labels Sep 12, 2023
@camertron camertron changed the title Check radio group validation Enable validation messages on radio button and check box groups Sep 12, 2023
@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@primer primer deleted a comment from github-actions bot Sep 12, 2023
@primer primer deleted a comment from github-actions bot Sep 12, 2023
@primer primer deleted a comment from github-actions bot Sep 12, 2023
@primer primer deleted a comment from github-actions bot Sep 12, 2023
@primer primer deleted a comment from github-actions bot Sep 12, 2023
@primer primer deleted a comment from github-actions bot Sep 12, 2023
@camertron camertron marked this pull request as ready for review September 12, 2023 23:11
@camertron camertron requested review from a team and keithamus September 12, 2023 23:11
@camertron camertron temporarily deployed to preview September 12, 2023 23:19 — with GitHub Actions Inactive
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camertron camertron temporarily deployed to preview September 13, 2023 17:23 — with GitHub Actions Inactive
…_components into check_radio_group_validation
@camertron camertron temporarily deployed to preview September 13, 2023 21:49 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to preview September 14, 2023 08:35 — with GitHub Actions Inactive
@camertron camertron merged commit 3f7e619 into main Sep 14, 2023
27 checks passed
@camertron camertron deleted the check_radio_group_validation branch September 14, 2023 23:10
@camertron camertron temporarily deployed to preview September 14, 2023 23:10 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants