Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade popover-polyfill to latest #2323

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

keithamus
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This upgrades @oddbird/popover-polyfill to 0.3.0, and removes redundant CSS.

Screenshots

No visual changes.

Integration

Upstream code will also need to make sure it uses [email protected]

List the issues that this change affects.

Fixes #2209

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: da3a31a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added javascript Pull requests that update Javascript code css Pull requests that update CSS code labels Oct 23, 2023
@keithamus keithamus marked this pull request as ready for review October 23, 2023 14:50
@keithamus keithamus requested a review from a team as a code owner October 23, 2023 14:50
@keithamus keithamus requested review from a team, simurai and camertron October 23, 2023 14:50
@keithamus keithamus enabled auto-merge (squash) October 24, 2023 11:36
@keithamus keithamus merged commit c481ed2 into main Oct 24, 2023
27 checks passed
@keithamus keithamus deleted the upgrade-popover-polyfill-to-latest branch October 24, 2023 22:04
@keithamus keithamus temporarily deployed to preview October 24, 2023 22:04 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code javascript Pull requests that update Javascript code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

„New“ menu always shown on iPad
2 participants