-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow NavList to paginate multiple groups #2406
Conversation
🦋 Changeset detectedLatest commit: f4cc085 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like there's a failing system test |
This is looking great! Just that one system test issue, but I'm a soft 🚢 |
Thanks @jonrohan & @camertron - that system test that I missed has been updated! |
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR moves the "show more" pagination to the NavList group level, allowing each group to receive pagination within a NavList. Previously, only the first group would receive pagination.
Demo
navlist.mov
Integration
This change shouldn't break existing usage of "show more", and when this change is integrated into GitHub dotcom we can remove the local workaround to allow pagination in the left-hand global side panel groups.
List the issues that this change affects.
Closes #1885
Risk Assessment
What approach did you choose and why?
I largely implemented the same workaround that I did when we added pagination to the NavList in dotcom's global side panel, which is pulling all "show more" related code out of the
nav-list
element and into a newnav-list-group
element. With that change, each group can now manage its own pagination state.Anything you want to highlight for special attention from reviewers?
focusMarkers
behavior still work as expected with this change? It seems like it to me but it's worth double-checking.Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.