Support font_size and border_radius in classify/utilities #2447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This adds support to the
Primer::Classify::Utilities
class for converting class names likef3
androunded-0
to the system args/values offont_size: 3
andborder_radius: 0
, respectively.Integration
I don't believe so. Was there a reason that this wasn't added that causes conflicts?
List the issues that this change affects.
Closes # #2448
Risk Assessment
What approach did you choose and why?
REPLACEMENT_KEYS
hash constant that targetedf
andradius
class namesAnything you want to highlight for special attention from reviewers?
Am I missing anything?
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.