Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tsconfig.json target to es2020 #2604

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Update tsconfig.json target to es2020 #2604

merged 4 commits into from
Feb 13, 2024

Conversation

mattcosta7
Copy link
Contributor

@mattcosta7 mattcosta7 commented Feb 13, 2024 •
edited
Loading

What are you trying to accomplish?

Updates the target to es2020 to avoid downleveling features that should be baked into all of our supported browsers

Integration

No changes to production code

List the issues that this change affects.

fixes #2605

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Update tsconfig

Anything you want to highlight for special attention from reviewers?

Do we need to consider this a breaking change? Most consumers should be downleveling this if they need additional support, but technically it could be considered as such

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mattcosta7
Update tsconfig.json target to es2020
6aeea63 
Updates the target to es2020 to avoid downleveling features that should be baked into all of our supported browsers
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4c9874f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mattcosta7
mattcosta7 commented Feb 13, 2024
View reviewed changes
.changeset/stupid-pears-flow.md Outdated
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be considered breaking, but I don't know that it actually needs to be, if we don't believe this package is used by consumers who don't have a transpile step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't release major versions of PVC at the moment. I would bump the minor version for this change, since it's not necessarily backwards-compatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I went back and forth between them! Updated

@mattcosta7 mattcosta7 self-assigned this Feb 13, 2024
@mattcosta7 mattcosta7 marked this pull request as ready for review February 13, 2024 21:46
@mattcosta7 mattcosta7 requested review from a team and keithamus February 13, 2024 21:46
camertron
camertron reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, I'm a 👍 otherwise.

.changeset/stupid-pears-flow.md Outdated
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't release major versions of PVC at the moment. I would bump the minor version for this change, since it's not necessarily backwards-compatible.

@mattcosta7 mattcosta7 mentioned this pull request Feb 13, 2024
Closed
10 tasks
camertron
camertron approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@camertron camertron merged commit 8d67631 into main Feb 13, 2024
29 of 30 checks passed
@camertron camertron deleted the mattcosta7-patch-1 branch February 13, 2024 21:53
@primer primer bot mentioned this pull request Feb 13, 2024
Merged
@openprojectci openprojectci mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees

@mattcosta7 mattcosta7

Labels
minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ts compilation target to es2020
2 participants
@mattcosta7 @camertron