Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi select form inputs #2627

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Multi select form inputs #2627

merged 3 commits into from
Feb 27, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Feb 21, 2024

What are you trying to accomplish?

Rails select boxes support selecting multiple values, but the PVC Select form input and view component do not. This PR adds the multi-select functionality.

Screenshots

A screenshot of a Lookbook preview showing two select boxes, a single-select on the top and a multi-select on the bottom.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Rails already supports multi-select boxes, so all I had to do was style the input correctly and add some previews/tests.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: a31af39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review February 21, 2024 23:24
@camertron camertron requested a review from a team as a code owner February 21, 2024 23:24
@camertron camertron requested review from a team, rezrah and keithamus February 21, 2024 23:24
@camertron camertron merged commit 226481e into main Feb 27, 2024
30 checks passed
@camertron camertron deleted the multi_select_form_inputs branch February 27, 2024 19:50
@primer primer bot mentioned this pull request Feb 27, 2024
@primer primer bot mentioned this pull request Mar 15, 2024
jonrohan pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants