Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label_wrap param to Beta::Button #2751

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Apr 5, 2024

  • Adds a new param that allows button label text to wrap
  • Fixes overflow for SegmentedControl

After testing this change behind in feature flag in dotcom, we've come to the conclusion that the change is too risky. Instead, we're introducing it with a param so we can target specific areas with overflow issues.

Tested in dotcom:

change username button with text wrapping

@langermank langermank requested review from a team as code owners April 5, 2024 18:58
Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 1589e9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 8, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank requested a review from a team as a code owner April 8, 2024 16:49
@langermank langermank enabled auto-merge (squash) April 8, 2024 18:33
@langermank langermank merged commit b1fef3c into main Apr 8, 2024
30 of 31 checks passed
@langermank langermank deleted the add-button-wrap-param branch April 8, 2024 18:36
@primer primer bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants