actionmenu: ensure focus falls back to invoking element when dialogs are closed #2983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Currently if an actionmenu opens a dialog, and that dialog is subsequently closed, focus is not automatically restored to the action menu invoker. It should be.
Screenshots
Gosh if I had time in my day to make a video...
Integration
Shouldn't need to.
List the issues that this change affects.
Closes https://github.com/github/primer/issues/3491, https://github.com/github/accessibility-audits/issues/7683
Risk Assessment
What approach did you choose and why?
I used the existing dialog close behaviour, which was only triggered if the dialog was a descendant of the menu. This guard got moved to the relevant parts which hide the actionmenu wrapper, but it retains the focus move code.
I've also added extra guards around the focus code to ensure we're not overriding focus changes for instances that shift focus on dialog close.
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Added/updated documentationN/AAdded/updated previews (Lookbook)N/ATake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.