Add a linter for migrating from SelectMenu -> SelectPanel #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0744f02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
commented
Aug 21, 2024
| @@ -6,7 +6,7 @@ module ERBLint | |||
| module Linters | |||
| # Counts the number of times a HTML Blankslate is used instead of the component. | |||
| class BlankslateComponentMigrationCounter < BaseLinter | |||
| MESSAGE = "We are migrating Blankslate to use [Primer::Beta::Blankslate](https://primer.style/view-components/components/beta/blankslate), please try to use that instead of raw HTML." | |||
| MESSAGE = "We are migrating Blankslate to use [Primer::Beta::Blankslate](https://primer.style/components/blankslate/rails/beta), please try to use that instead of raw HTML." | |||
There was a problem hiding this comment.
This is not strictly part of this PR, but I noticed the link was wrong so I decided to fix it.
camertron
force-pushed
the
select_menu_linter
branch
from
1748120
to
dfbcacb
Compare
jonrohan
approved these changes
Aug 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR adds a linter for the old CSS-based
SelectMenucomponent. The linter will suggest using the newSelectPanelcomponent instead.Integration
No changes necessary in production.
List the issues that this change affects.
Closes https://github.com/github/primer/issues/3876
Risk Assessment
What approach did you choose and why?
I leveraged our existing CSS linter infrastructure.
Accessibility