Remove SelectPanel's backdrop #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6969c2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
requested review from
lukasoppermann and
siddharthkp
and removed request for
a team
JoyceZhu
approved these changes
Aug 22, 2024
|
JoyceZhu
approved these changes
Aug 22, 2024
siddharthkp
approved these changes
Aug 23, 2024
langermank
approved these changes
Aug 23, 2024
|
@siddharthkp you're absolutely right 😄 We actually don't support a modal variant at the moment, but we'll need to consider adding a backdrop if/when we do. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
SelectPanelcomponent should not render a backdrop. See: https://github.slack.com/archives/C06F2US6HU6/p1724361897840679Screenshots
Integration
No changes necessary in production.
List the issues that this change affects.
Closes https://github.com/github/primer/issues/3878
Risk Assessment
Accessibility
Merge checklist
- [ ] Added/updated tests- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.