fix accessibility violation by moving text to top of dialog on SelectPanel #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 83b043c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
owenniblock
requested review from
camertron and
mperrotti
and removed request for
keithamus and
mperrotti
keithamus
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
This LGTM but @langermank or @lukasoppermann should also check this over.
camertron
approved these changes
Sep 23, 2024
langermank
approved these changes
Sep 25, 2024
|
Yeah I agree with adding a bit more padding 👍 |
|
Looks like tests are failing under Rails main, I'll take a look. EDIT: should be fixed by #3118 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
The accessibility violation goes away if the content is presented at the top of the container element. Maybe it's not the best design wise so suggesting we make this change for now and then see if design want us to do some work to fix this in a different way.
Screenshots
Screenshots can be found here
Integration
No
List the issues that this change affects.
Closes https://github.com/github/primer/issues/3958
Closes https://github.com/github/primer/issues/4019
Risk Assessment
Just a small layout tweak.
What approach did you choose and why?
This is the simplest way to fix the accessibility violation.
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.