Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update details_menu_migration linter config #3139

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Update details_menu_migration linter config #3139

merged 3 commits into from
Oct 21, 2024

Conversation

jamieshark
Copy link
Contributor

@jamieshark jamieshark commented Oct 7, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

I am changing the expected config from an array of regex to an array of strings, since .yml will cast any regex as a string to the config anyway. I also updated the linter to transform the individual array entries into Regexp as well.

Screenshots

Integration

List the issues that this change affects.

Towards https://github.com/github/accessibility/issues/6473

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jamieshark jamieshark requested a review from a team as a code owner October 7, 2024 17:44
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: be070c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camertron camertron merged commit b650344 into main Oct 21, 2024
37 checks passed
@camertron camertron deleted the erb-lint-config branch October 21, 2024 20:17
@primer primer bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants