Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow form groups to accept system arguments #3149

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Oct 14, 2024

What are you trying to accomplish?

This PR modifies Primer forms' group component to accept system arguments.

Integration

No changes necessary in production.

List the issues that this change affects.

Closes #3142

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
    - [ ] Added/updated documentation
    - [ ] Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 2d453b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review October 14, 2024 17:34
@camertron camertron requested a review from a team as a code owner October 14, 2024 17:34
@camertron camertron requested review from keithamus and jonrohan and removed request for keithamus October 14, 2024 17:34
@camertron camertron merged commit b9cce66 into main Oct 14, 2024
40 checks passed
@camertron camertron deleted the form_groups_sys_args branch October 14, 2024 18:21
@primer primer bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormGroup does not honor system arguments
2 participants