fix(qe): forward join fields for nested filters in m2m #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4994 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
jkomyno
reviewed
Aug 30, 2024
query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/many_relation.rs
Outdated
Show resolved
Hide resolved
jkomyno
reviewed
Aug 30, 2024
query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/many_relation.rs
Outdated
Show resolved
Hide resolved
jkomyno
reviewed
Aug 30, 2024
| } else { | ||
| rf.related_field().referenced_fields() | ||
| } | ||
| rf.linking_fields().as_scalar_fields().unwrap_or_default() |
There was a problem hiding this comment.
Can we add a comment here please?
There was a problem hiding this comment.
This can be done after today's release.
Co-authored-by: Alberto Schiabel <[email protected]>
jkomyno
approved these changes
Sep 2, 2024
jkomyno
added a commit
that referenced
this pull request
Sep 2, 2024
* test(query-engine): add regression test for prisma/prisma#25103 * Fix the IDs in schema_25103 * Add the actual failing query in prisma_25103 * Add repro for 25104 * Support m2m in join_fields * Exclude mongodb for now * Add a test with different pk names * Update the test to be closer to the user's query Co-authored-by: Alberto Schiabel <[email protected]> --------- Co-authored-by: jkomyno <[email protected]> Co-authored-by: Alberto Schiabel <[email protected]>
aqrln
commented
Sep 2, 2024
| schema.to_owned() | ||
| } | ||
|
|
||
| #[connector_test(schema(schema_25104), exclude(MongoDb))] |
There was a problem hiding this comment.
this should have been changed before merging and the schema should use #m2m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
someclauses prisma#23742