fix: timed out fetching a new connection from the connection pool.

[youxq]

Fixes: prisma/prisma#25162

solution

Change new MakeTlsConnector, which is executed by each PostgreSql::new, to obtain it from MakeTlsConnectorManager.get_connector. The logic of get_connector is to create new MakeTlsConnector in the first call and save the created tls connector. All subsequent calls will clone the tls connector from the first call, thereby reducing the overhead of the new MakeTlsConnector.

test results

Use https://github.com/youxq/prisma-connection-test tool to test.

The bug of Timed out fetching a new connection from the connection pool. was successfully triggered before the fix.

It no longer appears after the fix.

[CLAassistant]

All committers have signed the CLA.

[rwest202]

Is this ready to merge?

[aqrln]

Thanks so much for the PR and sorry for the delay, I'll get to it soon (tomorrow or early next week).

[codspeed-hq]

CodSpeed Performance Report

Merging #4998 will not alter performance

_{Comparing youxq:fix/tls-builder (4ac07af) with main (4b67dc7)}

Summary

✅ 11 untouched benchmarks

[youxq]

I have fixed the lint issue. Please help trigger the checks workflow again. Thanks.

[michael-rzero]

Would love to see this merged

[semoal]

Seeing this error in production environment, even using pgbouncer, would be nice to ship this in the next release

[TheBubbleDuck]

Agreed with others! We are having similar issues as well and it would be great to see this make it into a release. Even if there is was an RC or beta to test it out to get more consensus and field testing if that would help community feel better about it.

[rwest202]

Looks like this has stalled out again, we are seeing this issue on our live app

[youxq]

@aqrln @anton-ax Hi, I have resolved the conflict. Please take a look. thanks

[tmm1]

@aqrln can we get some movement here

cc #5011

[michael-rzero]

Would love to see this released, would fix an issue we're seeing

[aqrln]

It's on my radar, sorry for the lack of movement so far! I approved the CI run for the latest changes.

[michael-rzero]

Awesome, thank you @aqrln - looks like all passed - thank you for keeping this on the go :)

[youxq]

Sorry, I just fixed another rustfmt issue, please help trigger the CI again, thanks @aqrln

[ajhollowayvrm]

Would LOVE to see this merged in as I've recently run into this issue while running Prisma in Kubernetes in GCP.

[aqrln]

Hey folks, I've triggered a dev release, you can test it by using Prisma version 5.22.0-integration-engines-5-22-0-22-gh-4998-integration-eb7519dcdf552de090269ebfa2beabc8e1a13e1b.1 (just make sure to install the exact version without ^, otherwise you can get other random stuff from the integration dist-tag built from other branches).

[tmm1]

FWIW we've been running this in production for a few days now and it works as advertised.

[aqrln]

Looks great to me, thanks for doing this work and sorry for the delay in reviewing!