Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clippy fixes + tests for zero-length encoding of varlen columns #338

Merged
merged 21 commits into from
Jun 6, 2024
Merged

chore: clippy fixes + tests for zero-length encoding of varlen columns #338

merged 21 commits into from
Jun 6, 2024

Conversation

Weakky
Copy link
Contributor

@Weakky Weakky commented Apr 23, 2024 •
edited
Loading

Overview

Follow-up PR to #315.

  • The initial PR added a bunch of tests, but none actually sent data to the database. These tests ensure the encoding is fixed.
  • Lots of clippy fixes because of chrono deprecated functions
  • Refreshed local certificates because they were expired
  • Fixed read rights of certificates for mssql 2022
  • Downgraded macos CI to macos-12 because docker doesn't work anymore on latest version

TODO

  • Add regular tests for VARCHAR(MAX) and co

@Weakky
chore: add tests for zero-length encoding of varlen columns
cf9eecd
@Weakky
clippy fixes
b6848ea
@Weakky
update certs
3290518
@Weakky
Merge branch 'main' into tests/zero-length-values
fe0cfc3
@Weakky
clippy fixes
5595382
@Weakky
add dt2 decoding case
f071fb4
@Weakky
Revert "update certs"
aa6ab2c 
This reverts commit 3290518.
@Weakky
update certs again...
c1861a2
@Weakky
fix certificate read rights
8368c12
@Weakky
try installing docker on macos differently
46ff76f
@Weakky
try installing docker on macos differently
1a0d782
@Weakky
try installing docker on macos differently
05e3cd2
@Weakky
try installing docker on macos differently
f82dff6
@Weakky
try installing docker on macos differently
98d2162
@Weakky
try installing docker on macos differently
ab33889
@Weakky
try installing docker on macos differently
e4e92c8
@Weakky
try installing docker on macos differently
04f108b
@Weakky
cleanup
ca723a5
@Weakky
ensure NaiveDateTime still works
df3699a
@Weakky
try installing docker on macos differently..... hello jan
acab8af
@Weakky Weakky changed the title add tests for zero-length encoding of varlen columns chore: clippy fixes + tests for zero-length encoding of varlen columns Jun 4, 2024
@Weakky Weakky merged commit b197032 into main Jun 6, 2024
25 of 27 checks passed
@Weakky Weakky deleted the tests/zero-length-values branch June 6, 2024 14:33
@aersam aersam mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weakky @SevInf