Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table name can be in multiple parts #58

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Table name can be in multiple parts #58

merged 1 commit into from
Jun 15, 2020

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Jun 15, 2020

In some cases the table name metadata comes in multiple parts. This caused corrupted data when reading the IMAGE type, and the PR should fix the bug in #56.

tomhoule
tomhoule approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch :/

I don't know the protocol so I can't comment on that, but the code looks good.

@pimeys pimeys merged commit 1d07ca9 into master Jun 15, 2020
@pimeys pimeys deleted the table-name-fix branch June 15, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackydoo wackydoo wackydoo left review comments

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pimeys @tomhoule @wackydoo