Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass hostname to tls_handshake #62

Merged
merged 2 commits into from
Jun 24, 2020
Merged

pass hostname to tls_handshake #62

merged 2 commits into from
Jun 24, 2020

Conversation

esheppa
Copy link
Contributor

@esheppa esheppa commented Jun 17, 2020

No description provided.

@esheppa esheppa requested a review from pimeys June 24, 2020 12:42
pimeys
pimeys reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@pimeys pimeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good? What was the problem originally with this and why it works now?

@esheppa
Copy link
Contributor Author

esheppa commented Jun 24, 2020

Good question, prior to this change it wasn't possible to connect to Azure SQL with TrustServerCertificate=no as the TLS connect function didn't have a hostname to compare against the server's certificate

@pimeys pimeys merged commit 422200d into master Jun 24, 2020
@pimeys pimeys deleted the verify-hostname branch June 24, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimeys pimeys pimeys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esheppa @pimeys