Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: packages/manager/src/lib/fetch.ts #961

Merged
merged 2 commits into from
May 4, 2023
Merged

refactor: packages/manager/src/lib/fetch.ts #961

merged 2 commits into from
May 4, 2023

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR refactors mm/http-keep-alive to simplify its fetch() wrapper.

This PR also adds clear messaging that the wrapper is (potentially) temporary until node-fetch/node-fetch#1736 is merged.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🦕

@angeloashmore angeloashmore changed the title refactor: src/lib/fetch.ts refactor: packages/manager/src/lib/fetch.ts May 3, 2023
@angeloashmore angeloashmore mentioned this pull request May 3, 2023
Merged
4 tasks
bapmrl
bapmrl approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@bapmrl bapmrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @angeloashmore! I'll just fix a small typo.

@MarcMcIntosh MarcMcIntosh merged commit 78c6d9a into mm/http-keep-alive May 4, 2023
@MarcMcIntosh MarcMcIntosh deleted the aa/http-keep-alive branch May 4, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bapmrl bapmrl bapmrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angeloashmore @bapmrl @MarcMcIntosh