Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize vtk file read-in behavior #222

Merged

Conversation

fractalsbyx
Copy link

Previously each vtk input would be read/parsed multiple times if it contained multiple needed fields. Now it will read each vtk only once. (per processor)

fractalsbyx and others added 4 commits August 26, 2024 19:48
Previously each vtk input would be read/parsed multiple times if it contained multiple fields. Now it will read each vtk only once. (per processor)
Copy link
Contributor

@landinjm landinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, this rearranges the loop structure of the vtk read in so the file is parsed once for all input fields rather than once for each field ( O(n) to O(1)?

Otherwise, there are just a few small fixes.

Thanks for the PR!

src/matrixfree/initialConditions.cc Show resolved Hide resolved
src/matrixfree/initialConditions.cc Outdated Show resolved Hide resolved
src/matrixfree/initialConditions.cc Outdated Show resolved Hide resolved
@landinjm landinjm merged commit a6beed8 into prisms-center:development Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants