Transcript usage inclusion into the codebase #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves a tep forward to the NIMFS-centric API. First, removes all the `_Witness` & `_Instance` structs for CCS & CCCS as they added a bunch of overhead. Sedonc, it also re-assembles internal fm APIs so that they ask for slices instead of refs to `Vec`. Finally, reassembles all the tests to indeed modify CCS & CCCS interaction as described avobe.
Removes CCS & CCS_MLEs from the struct as well as renaming some variables. Aside from that, the functions are being modified so that they always get the removed fields as refs.
This gets rid of conversions that made no sense from a theoretical standpoint and were overtaken by a better API design.
Since we need to generate LCCCS instances from no-where to actually be able to test things or startup the NIMFS object.
LCCCS already contains `z` inside of it. So it's non-sensical to require twice the same thing that was already served to the struct in the pass as a creation attribute.
This allows to either generate a `Multifolding` instance from all of it's params or, instead, from the first `z` and confectioning the LCCCS.
This introduces `Transcript` into NIMFS to have a correct way to fetch randomness to create Sigmans, Thetas and any other randomness required by the protocol in the Sum Check for example. - The commit modifies the `init` to now receive a seed label for the Transcript. It also adds the first witness & CCS M MLE into the transcript. - The commit also adds an associated fn for NIMFS `gen_r_x` which allows the NIMFS to query the challenge enough times to actually generate the `r_x` vector needed to compute sigmas and thetas.
Now, instead of getting passed-by randomness, the NIMFS generates `r_x_prime` and `rho` by querying the inner transcript instance it holds.
CPerezz
force-pushed
the
transcript_inclusion
branch
from
7f99930
to
45b93a9
Compare
|
Note that since I'm stupid and decided to squash #41 accidentally, I could not rebase here.. |
oskarth
approved these changes
Aug 1, 2023
asn-d6
reviewed
Aug 1, 2023
| let w_comm = <G as Group>::CE::commit(&ck, &w); | ||
|
|
||
| let r_x: Vec<G::Scalar> = vec![G::Scalar::random(&mut rng); ccs.s]; | ||
| let v = ccs.compute_v_j(&z, &r_x, &ccs_mle); | ||
| // Query challenge to get initial `r_x`. |
There was a problem hiding this comment.
Yikes, 4 lines to squeeze a challenge? Can we add helper functions for this? Maybe just make gen_r_x() take as input the size?
There was a problem hiding this comment.
This only happens here because the NIMFS struct hasn't been created yet. From here on, there's a fn that does exactly what you need called exactly as you said.
Is that ok? Or you'd still prefer a helper fn not associated to any struct to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged unti #41 gets into
main.The PR introduces usage from the associated trait/type of
GroupcalledTranscriptEngineTraitto perform the Fiat-Shamir inside the multifolding for the Sigmas and Thetas computations as well as gammas.This should be rebased on the top of
mainonce #41 is merged and then reviewed. As there could be places where FS should be applied but it isn't.