Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra metadata to metadata::Region or Region itself. #112

Open
CPerezz opened this issue Dec 23, 2022 · 8 comments · Fixed by #123
Open

Add extra metadata to metadata::Region or Region itself. #112

CPerezz opened this issue Dec 23, 2022 · 8 comments · Fixed by #123
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CPerezz
Copy link
Member

CPerezz commented Dec 23, 2022

See: https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/994/files#r1052139018 for more details.

@ed255 description:

Ideally, given an impl Circuit loaded with witness data, we would obtain a list of regions with medatada. This metadata would be the list of columns used in the region, and for each column, the range of rows assigned.

@ed255
Copy link
Member

ed255 commented Jan 4, 2023

Ideally, given an impl Circuit loaded with witness data, we would obtain a list of regions with medatada. This metadata would be the list of columns used in the region, and for each column, the range of rows assigned.

@CPerezz
Copy link
Member Author

CPerezz commented Jan 4, 2023

I like it!
We already picked up tasks for this week's sprint. But will definitely purpose it for the next one!

@davidnevadoc
Copy link

I think the issue is not quite solved. The new functions allow to access some extra information from the MockProver but nothing else.
This is really helpful to check for bugs like the witness-dependent sized circuits but it doesn't give us extra info in configure time (which is what we need to solve privacy-scaling-explorations/zkevm-circuits#1028 )

@davidnevadoc davidnevadoc reopened this Mar 31, 2023
@davidnevadoc
Copy link

Any thoughts on this @CPerezz @ed255 ?

@CPerezz
Copy link
Member Author

CPerezz commented Apr 24, 2023

We could have a quick chat to revisit the problem.
But I'm not sure this is still a concern (or a big prio at least).

@davidnevadoc
Copy link

I'd agree that we are not in a hurry. However it would be nice to solve as it is blocking this other issue privacy-scaling-explorations/zkevm-circuits#1028

@CPerezz
Copy link
Member Author

CPerezz commented Apr 25, 2023

That's right! @ed255 should we bring it to this week's agenda??

@ed255
Copy link
Member

ed255 commented Apr 25, 2023

That's right! @ed255 should we bring it to this week's agenda??

Sounds good to me!

iquerejeta pushed a commit to input-output-hk/halo2 that referenced this issue May 8, 2024
…-hk/dev-fix/double-add-tests

Resolve "Improvements for "Double-and-Add testing"
@davidnevadoc davidnevadoc added the good first issue Good for newcomers label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
3 participants