Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the changes introduced in getrandom import as dep #285

Closed
CPerezz opened this issue Feb 22, 2024 · 6 comments · Fixed by #286
Closed

Fix the changes introduced in getrandom import as dep #285

CPerezz opened this issue Feb 22, 2024 · 6 comments · Fixed by #286
Labels
bug Something isn't working

Comments

@CPerezz
Copy link
Member

CPerezz commented Feb 22, 2024

Changes done in 09aaf97 should be reverted and we should bring back the dependency import only as dev-dependency.

@duguorong009
Copy link

@CPerezz
I found the origin of issue & created the PR to fix it.
Pls review the PR.

@duguorong009
Copy link

One additional topic is that the rust-toolchain can be downgraded to v1.67.0 as before.
Do you think it is better to keep the rust-toolchain as v1.73.0? or downgrade it to v1.67.0? @CPerezz

@CPerezz
Copy link
Member Author

CPerezz commented Feb 23, 2024

One additional topic is that the rust-toolchain can be downgraded to v1.67.0 as before. Do you think it is better to keep the rust-toolchain as v1.73.0? or downgrade it to v1.67.0? @CPerezz

I'd roll it back. Unless until a bump is needed.

@duguorong009
Copy link

One additional topic is that the rust-toolchain can be downgraded to v1.67.0 as before. Do you think it is better to keep the rust-toolchain as v1.73.0? or downgrade it to v1.67.0? @CPerezz

I'd roll it back. Unless until a bump is needed.

Okay, then, how about adding the commit of rollback to #286 ?

@CPerezz
Copy link
Member Author

CPerezz commented Feb 23, 2024

One additional topic is that the rust-toolchain can be downgraded to v1.67.0 as before. Do you think it is better to keep the rust-toolchain as v1.73.0? or downgrade it to v1.67.0? @CPerezz

I'd roll it back. Unless until a bump is needed.

Okay, then, how about adding the commit of rollback to #286 ?

Let's do it to yes! At the end both go together! :)

@duguorong009
Copy link

NOTE: Because of the CI failure, we keep the MSRV as 1.73.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants