fix: reset the changes introduced in getrandom import as dep
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPerezz
approved these changes
Feb 23, 2024
Cargo.toml
Outdated
Comment on lines
8
to
9
| ] | ||
| resolver = "2" No newline at end of file | ||
| ] |
There was a problem hiding this comment.
Was the resolver 2 an issue for the getrandom usage as dev-dep?? I'd have expected the oposite 😮
There was a problem hiding this comment.
Yes, it was.
Without this option, the default resolver is "1".
It resolves the issue.
There was a problem hiding this comment.
That's really weird.. resolver = 2 is the "powerful" one. The one that allows same dep with different features for dep/dev-dep. So it's confusing that the resolver=1 solves the issue :/
|
Seems that |
Done it. |
duguorong009
force-pushed
the
gr@fix-getrandom-import
branch
from
370cc1b
to
8f369ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getrandomcrate import change caused by refactor: move thehalo2_common::arithmetictohalo2_backend(post fe-be split) #281Related issues
Changes
getrandomcrate asdev-dependencyforwasm32-*target build CIresolver = "2"option from workspace cargo.toml