Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove V2 from type names #312

Merged
merged 3 commits into from
Apr 12, 2024
Merged

chore: remove V2 from type names #312

merged 3 commits into from
Apr 12, 2024

Conversation

ed255
Copy link
Member

@ed255 ed255 commented Apr 9, 2024

There were a few type names that included "V2" after the frontend-backend split but they don't collide between frontend-middleware-backend so the "V2" was unneeded. With this PR the names after the frontend-backend split will be uniform.

Resolve #263

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@duguorong009 duguorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the PR looks good.
I left some comments about keygen_pk_v2 & keygen_vk_v2 in backend crate.
Simply, I think it is good to remove all _v2 suffix.

halo2_backend/src/plonk/keygen.rs Outdated Show resolved Hide resolved
halo2_backend/src/plonk/keygen.rs Outdated Show resolved Hide resolved
Copy link

@duguorong009 duguorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ed255 ed255 merged commit d03d6c7 into main Apr 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[post frontend-backend split] Discuss names for new types / functions
3 participants