Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Expression copiable using singleton arena #354

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adria0
Copy link
Member

@adria0 adria0 commented Jun 17, 2024

NOTE: Relevant files to review are halo2_frontend/src/plonk/circuit/{expession.rs, arena.rs}

This an experiment about making expression copiable. To implement this we go with this strategy:

  • Create a type called ExprRef<F> that contains the index (usize) of an expression stored in an specific arena.
  • Modify the struct Expression to use ExprRef instead the a recursive Expression that makes it non-copiable.
  • In order to access to the Expression arenas, we create a new trait that allows to access to the expression arena for an specific field, called FieldFront. Mainly we change all frontend from Field to FieldFront, making arena accessible everywhere.
pub trait FieldFront: Field {
    // Since base trait is not referenciable, we need a way to access it.
    // This is necessary to provide a way to transform fields from/to backend.
    type Field: Field;
    fn into_field(self) -> Self::Field;
    fn into_fieldfront(f: Self::Field) -> Self;

    // Allocate a new expression
    fn alloc(expr: Expression<Self>) -> ExprRef<Self>;

    // Get an expression
    fn get(ref_: &ExprRef<Self>) -> Expression<Self>;

    // Replace an expression
    fn replace(expr: Expression<Self>, ref_: &ExprRef<Self>);
}

This means:

  • Library users needs to change <Field> for <FieldFront> and automatically all their Expressions are automatically copiable. This is thread-safe.
  • Arenas are not dropped and lives until the whole program is finished.
  • Arenas are field-especific and cannot be defined outside the halo2_crate ( this is due that is not possible to implement external traits on external types ).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.97065% with 86 lines in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (32599e8) to head (c8c7ff9).
Report is 1 commits behind head on main.

Files Patch % Lines
halo2_frontend/src/plonk/circuit/expression.rs 69.11% 63 Missing ⚠️
halo2_frontend/src/dev/failure.rs 12.50% 7 Missing ⚠️
halo2_frontend/src/plonk/circuit.rs 0.00% 4 Missing ⚠️
halo2_proofs/src/plonk/prover.rs 98.05% 4 Missing ⚠️
halo2_frontend/src/dev/tfp.rs 0.00% 3 Missing ⚠️
halo2_proofs/src/plonk.rs 50.00% 2 Missing ⚠️
halo2_frontend/src/dev/failure/emitter.rs 0.00% 1 Missing ⚠️
halo2_frontend/src/dev/gates.rs 0.00% 1 Missing ⚠️
...o2_frontend/src/plonk/circuit/constraint_system.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   82.09%   81.81%   -0.29%     
==========================================
  Files          83       83              
  Lines       17228    17452     +224     
==========================================
+ Hits        14143    14278     +135     
- Misses       3085     3174      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adria0 adria0 changed the title [WIP] Make Expression copiable [WIP] Make Expression copiable using singleton arena Jun 17, 2024
@adria0 adria0 marked this pull request as ready for review June 18, 2024 10:24
@adria0 adria0 changed the title [WIP] Make Expression copiable using singleton arena Make Expression copiable using singleton arena Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants