Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable instance query #96

Conversation

han0110
Copy link

@han0110 han0110 commented Aug 20, 2022

This PR aims to make KZG commitment scheme not to query the instance columns from prover, instead calculate the evaluation directly in verifier side.

Current implementation is adding a const QUERY_INSTANCE: bool in Prover and Verifier traits, then in create_proof and verify_proof it gets the instance evaluation from transcript or by evaluating respectively.

@han0110 han0110 force-pushed the feature/configurable-instance-query branch from 443818d to 669a02a Compare September 12, 2022 08:04
@han0110 han0110 force-pushed the feature/configurable-instance-query branch from 669a02a to 090c4d7 Compare September 12, 2022 08:09
@han0110 han0110 marked this pull request as ready for review September 12, 2022 08:09
@aguzmant103 aguzmant103 requested review from kilic and removed request for CPerezz September 22, 2022 11:22
jonathanpwang added a commit to jonathanpwang/snark-verifier that referenced this pull request Oct 16, 2022
in `halo2_proofs` main. Made modifications so that `plonk-verifier` now
works even without "Configurable instance query" privacy-scaling-explorations/halo2#96
@han0110 han0110 merged commit 5fc8ce8 into privacy-scaling-explorations:main Oct 22, 2022
@han0110 han0110 deleted the feature/configurable-instance-query branch February 9, 2023 08:06
iquerejeta added a commit to input-output-hk/halo2 that referenced this pull request May 8, 2024
…hk/dev-test/parallelize-endoscaling-tests

Parallelize endoscaling tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants