fix: do not cleanup thread all the time while doing parallel proof gen #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
fix/cleanup-threads-correctly
branch
from
7e59bc4
to
0b849b2
Compare
ctrlc03
force-pushed
the
fix/cleanup-threads-correctly
branch
from
0b849b2
to
59901c8
Compare
ctrlc03
force-pushed
the
fix/cleanup-threads-correctly
branch
from
59901c8
to
c30e104
Compare
ctrlc03
force-pushed
the
fix/cleanup-threads-correctly
branch
from
c30e104
to
ac9a91a
Compare
ctrlc03
force-pushed
the
fix/cleanup-threads-correctly
branch
from
ac9a91a
to
47a6749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There currently is a hanging issue with generating proofs within the hardhat tasks due to the different promises opening and closing handles to the same curve (reference: iden3/snarkjs#152)
Also, do not extract Vk every time but only once when generating proofs for multiple batches
Confirmation