Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added polygon and gnosis to supported networks and benchmark #1811

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

crisgarner
Copy link
Collaborator

Description

Added Polygon, Gnosis, and their testnet to supported networks, default configs, and benchmark updates.

Confirmation

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Sep 3, 2024 6:02pm

@crisgarner
Copy link
Collaborator Author

Squashed the commits and created a new PR for this @ctrlc03, removed the comment and pushed the benchmark for the website here

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Sep 3, 2024

Squashed the commits and created a new PR for this @ctrlc03, removed the comment and pushed the benchmark for the website here

👌 thanks - please remember to use rebase not merge from now on

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's not squashed there's a merge commit too

@ctrlc03 ctrlc03 assigned ctrlc03 and crisgarner and unassigned ctrlc03 Sep 3, 2024
@crisgarner crisgarner force-pushed the chore/benchmarks-polygon-gnosis branch from 64c77b5 to a8bd860 Compare September 3, 2024 17:43
@crisgarner
Copy link
Collaborator Author

Seems like it's not squashed there's a merge commit too

I was getting some errors on the e2e, related to the head commit and the merge from the UI kind of fixed it. Will create another branch and add the files, might be related to a merge I did few days ago to use the new script

@crisgarner crisgarner closed this Sep 3, 2024
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Sep 3, 2024

Seems like it's not squashed there's a merge commit too

I was getting some errors on the e2e, related to the head commit and the merge from the UI kind of fixed it. Will create another branch and add the files, might be related to a merge I did few days ago to use the new script

@crisgarner the exact button you used to merge dev to your branch is also a dropdown with an option to rebase. Next time you can select rebase instead and it will fix that error (for context the error means that your branch was behind dev, hence it needed a merge or rebase)

@crisgarner crisgarner reopened this Sep 3, 2024
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@crisgarner crisgarner merged commit 3428af2 into dev Sep 3, 2024
22 checks passed
@crisgarner crisgarner deleted the chore/benchmarks-polygon-gnosis branch September 3, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants