-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mpz-common): scoped! macro #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I look forward to the resolution of rust-lang/rust#70263 which will let us get rid of this and associated utilities. |
th4s
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
sinui0
force-pushed
the
feat/context-blocking
branch
from
May 29, 2024 18:20
9ec66f2
to
2e7b3ae
Compare
themighty1
approved these changes
May 30, 2024
sinui0
added a commit
that referenced
this pull request
May 31, 2024
commit 2f35271 Author: sinu.eth <[email protected]> Date: Fri May 31 06:36:31 2024 -0700 feat(mpz-common): scoped! macro (#143) commit 9b51bd4 Author: sinu.eth <[email protected]> Date: Fri May 31 06:35:16 2024 -0700 feat(mpz-common): Context::blocking (#141) * feat(mpz-common): Context::blocking * Apply suggestions from code review Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]> commit 8f0b298 Author: th4s <[email protected]> Date: Fri May 31 10:30:08 2024 +0200 Add IO wrapper for OLE (#138) * Add `mpz-ole` content of old branch. * Reworked message enum. * Refactored to work with new `mpz-ole-core`. * Add part of feedback. * Add more feedback. * Add opaque error type. * Add `Display` for `OLEErrorKind` * Use `ok_or_elese` for lazy heap alloc. * Adapted `mpz-ole` to `hybrid-array`. * WIP: Improving API of const generics... * Add random OT for `hybrid-array`. * Adapt `mpz-ole` to use new random OT. * Added feedback. * Use random OT over field elements instead of arrays. * Refactored ideal implementation to use `mpz-common`. * Added more feedback.
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
scoped!
macro which makes it easy to write closures which return scoped futures. This macro may end up being preferable to using thejoin
andtry_join
macros.