feat/hypernova serialization #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, proof and public inputs
dmpierre
force-pushed
the
feat/hypernova-serialization
branch
from
584989e
to
d6e0c41
Compare
CPerezz
reviewed
Sep 16, 2024
| @@ -309,4 +311,201 @@ pub mod tests { | |||
| assert!(verified); | |||
| println!("Decider verify, {:?}", start.elapsed()); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_decider_serialization() { | |||
There was a problem hiding this comment.
Just not sure on why do we have timers in this test. We can just write formal benchmarks if we want any no?
There was a problem hiding this comment.
Yup, I just followed what was done with nova, I don't mind removing timers. I agree that we could initiate some benchmarks, but I'm not sure that's on the priority list right now? Wdyt? cc @arnaucube
There was a problem hiding this comment.
sure, I use to place dbg! to know the timings while I test things, but agree with removing them.
Regarding benchmarks, I think that it's not a priority since we're still in the 'exploration phase' where things are not much optimized and we know for sure that are slower than they would be.
arnaucube
reviewed
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements serde for hypernova prover and verifier params, proof and public inputs. Serding the ccs could make serialization costs increase quickly, so I did not implement the
CanonicalDeserializetrait forHypernova,ProverParamsandVerifierParams.For testing, I followed the same logic as what is being done in
test_decider_serializationfor nova. Testing is done here.