-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watchlist problems #521
Conversation
pr held until new changes to 512 have been implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @danielgoldelman, it works. But also please change the readme accordingly.
I'd say delete your earlier readme change and instead say:
- When storing a Watchlist General Keyword, a user would be alerted the first time a keyword is entered or shared by a site
- For all other keyword categories, a user would be alerted every time the keyword is collected or shared
(assuming that is how it is and that this is the terminology from the UI; in any case please describe in a few sentences how the Watchlist works using the terms from the UI)
We first need to resolve the open points before we can merge here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes and everything that was fixed is working as intended!
OK, I am currently on the train, which is not ideal for testing this functionality. I will try in 11 hours or so with a more stable Internet connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I checked the General Keywords. The other ones I will check in more detail. We can start with the usability study.
No description provided.