Sql database #528
Closed
Sql database #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in our issue 59 (privacy-tech-lab/gpc-web-crawler#59), it'd be great to be able to use an sql db to store data for our crawling purposes. I implemented one to try it out. The rest api to use it is in our repo. More details in our issue 59.
To prevent this db from interfering with Privacy Pioneer's functionality, I added a toggle to turn post requests to the db on/off. By default, sql_db = false, meaning axios post request will not be sent.
|
Great work, @katehausladen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever you guys get to this--
As discussed in this issue, I added axios post requests to addEvidence.js to help us more effectively use privacy pioneer with our crawler. When sql_db = false (sql_db = false by default), then the only difference to privacy pioneer is that now axios is in its package.json; all other code added won't do anything.
Thanks so much!