Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Joining CanvasBlocker to the Add-Ons List #1787

Merged
merged 3 commits into from
May 5, 2020

Conversation

hugoncosta
Copy link
Contributor

@hugoncosta hugoncosta commented Mar 14, 2020

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1786

Description

Currently, CanvasBlocker is discretly mentioned under Browser Fingerprinting. Since it's a plugin like all the others, I believe it should join the Add-Ons. The order is indifferent, I put it in the middle. #1786

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

@hugoncosta hugoncosta requested a review from a team March 14, 2020 15:16
@netlify
Copy link

netlify bot commented Mar 14, 2020

Deploy preview for privacytools-io ready!

Built with commit 8be8849

https://deploy-preview-1787--privacytools-io.netlify.app

@Mikaela
Copy link
Contributor

Mikaela commented Mar 19, 2020

Netlify preview for the mainly edited page: https://deploy-preview-1787--privacytools-io.netlify.com/

This means the page you mostly edited which is in this case https://deploy-preview-1787--privacytools-io.netlify.com/browsers/#addons

Code repository of the project (if applicable): https://github.com/hugoncosta/privacytools.io

This means the project you edited which means Canvas Blocker, but I would also accept unapplicable if it was already listed even if as a worth mentioning.

I cannot review at the moment (see my GitHub status).

@dngray
Copy link
Collaborator

dngray commented Mar 22, 2020

This is not a good idea if you use privacy.resistFingerprinting = true.

We should include a warning regarding that.

@dngray
Copy link
Collaborator

dngray commented May 5, 2020

@dngray dngray self-requested a review May 5, 2020 05:08
dngray
dngray previously requested changes May 5, 2020
Copy link
Collaborator

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG needs optimizing

@dngray dngray self-assigned this May 5, 2020
@dngray
Copy link
Collaborator

dngray commented May 5, 2020

I'm thinking we could list this under advanced, paired with uMatrix as suggested https://github.com/privacytoolsIO/privacytools.io/issues/1877#issuecomment-623786468

I eventually want to move Cookie Autodelete out of there into another group "cookie management" or something like that and mention Containers/Temporary Containers as that's a better approach.

@dngray dngray changed the base branch from master to pr-add_canvasblocker May 5, 2020 09:36
@dngray dngray dismissed their stale review May 5, 2020 09:41

Will fix in branch

@dngray dngray merged commit 6ffed73 into privacytools:pr-add_canvasblocker May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feature Suggestion | Joining CanvasBlocker to the Add-Ons List
3 participants