feat(watch): --include CLI flag to watch additional files
#625
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hiroki osame <[email protected]>
- Incorporate review feedback into 'watch: include' test - Fix final stdout check for 'watch: include' test - Add new 'watch: exclude' test to ensure a file can be excluded from watch
- There is no need to alias --ignore with --exclude, remove the new flag - Handle --include flag inside options object like the --ignore flag - Improve include test to also ensure glob pattern works
- Before checking for substrings in stdout, strip ANSI escape codes
mdmower-csnw
commented
Aug 1, 2024
- On Windows, mixed path separators are output by the watch utility. Normalize on / before searching for expected output. - Remove wait on debounce and separate file writes based on stdout output.
Fix error seen on Windows CI: String.prototype.replaceAll called with a non-global RegExp argument
|
Thanks for all the CI reruns @privatenumber (and also sorry you had to keep rerunning). I had some trouble installing node-gyp on Windows so my testing was limited to Debian. |
|
@privatenumber - is there anything else you need from me for this PR? |
|
Sorry, hard to prioritize tsx these days. But eventually I'll have to figure out funding first so it makes sense for me to invest more time on tsx, and then I plan to work on a bunch of watch improvements including this. |
|
I was debating between naming it |
privatenumber
changed the title
--include CLI flag--include CLI flag to watch additional files
|
This issue is now resolved in v4.18.0. If you're able to, your sponsorship would be very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up from where #561 left off (it appears to have been abandoned), but there is actually very little of that PR remaining here. Notably, I didn't see it necessary to add
--excludewhich would only alias the--ignoreflag. Nonetheless, the chain of commits here reflects the original contribution.--includethat can be used to include additional file paths and glob patterns (same syntax as the--ignoreflag).--includeflag.Fixes #181