-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
@@ -1,4 +1,5 @@ | |||
exclude_paths: | |||
- vendor/**/* | |||
- ZeroBin/**/* | |||
- tests/**/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference here between two **
and one *
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know exactly but if have to guess,then they both are pretty same.I will update them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't guess. You can't ask for something to be merged if you don't know what the code does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I researched on this thing...they (* & ** ) are both same and does same work in this case for sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks.
I think this is your third pull request making similar changes to the codeclimate file. You should be updating a single pull request, or at least closing the pull requests you open that are no longer valid. |
yes i will close other pull requests......I created this since you hinted me to remove a line which was not needed.Is there anything else that i should add ?? |
The new pull request is present at....#355 |
Removed the tests directory as you recommended.
Updated the .codeclimate.yml file
Please review ...:)
#328