Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Updated the .codeclimate.yml file #342

Closed

Conversation

opg7371
Copy link

@opg7371 opg7371 commented Feb 21, 2016

Removed the tests directory as you recommended.
Updated the .codeclimate.yml file
Please review ...:)
#328

@@ -1,4 +1,5 @@
exclude_paths:
- vendor/**/*
- ZeroBin/**/*
- tests/**/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference here between two ** and one *?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly but if have to guess,then they both are pretty same.I will update them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't guess. You can't ask for something to be merged if you don't know what the code does.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I researched on this thing...they (* & ** ) are both same and does same work in this case for sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks.

@smcgregor
Copy link
Member

I think this is your third pull request making similar changes to the codeclimate file. You should be updating a single pull request, or at least closing the pull requests you open that are no longer valid.

@opg7371
Copy link
Author

opg7371 commented Feb 21, 2016

yes i will close other pull requests......I created this since you hinted me to remove a line which was not needed.Is there anything else that i should add ??
Should i reference this to the pull request that is still open??

@opg7371
Copy link
Author

opg7371 commented Feb 25, 2016

The new pull request is present at....#355
So i am closing this issue

@opg7371 opg7371 closed this Feb 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants