This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Lint the extension source codes of posting.app.js #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lint the extension source codes of posting.app.js using GJSLint (Google Closure Linter). In old posting.app.js was found 44 lint errors. Now file checked, no errors found.
| @@ -1,16 +1,12 @@ | |||
| /** | |||
| * @fileOverview This file handles the communication between | |||
| * fileOverview - This file handles the communication between | |||
There was a problem hiding this comment.
It looks like this might have been a capitalization issue, but the directive is correct. http://usejsdoc.org/tags-file.html
|
Thanks for the PR! The changes all look good, with the exception of the two inline comments I made. If you address them, I will merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint the extension source codes of posting.app.js using GJSLint (Google Closure Linter). In old posting.app.js was found 44 lint errors.
Fixed this type lint errors:
1). Invalid JsDoc tag: fileOverview
2). Extra space after "function"
3). Illegal comma at end of array literal
4). Extra space at end of line
5). Line too long
Now file checked, no errors found.