-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic support #200
Pydantic support #200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 43 44 +1
Lines 2355 2398 +43
Branches 173 176 +3
=======================================
+ Hits 2353 2396 +43
Misses 2 2
Continue to review full report at Codecov.
|
@prkumar . Don't know why it's failing. Tried to reproduce locally and it worked with all python versions. |
Looking at the job log in Travis (link), I see that pytest is failing:
I doubt this is an issue with the Python code you added, and since the tests are passing in master, I don't think this is an issue with a new py.test version either. If I had to guess, I think it may be the line change in Pipfile? |
83fcf71
to
4a17df1
Compare
Yes ! I've tried to run/debug on my machine and it worked (ohhh, what a surprise, hahaha). I'm also sure it's related with the Pipfile modification, but still not quite sure how... |
d402029
to
74ffbcb
Compare
Tests ok. Any updates @prkumar ? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @gmcrocetti! This looks good to me. You mentioned adding documentation for this. Is this still planned?
Thanks ! :) Yeap, hope I can finish this week. |
Docs updated ! Left a comment asking for your opinion. Ready for review ! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing this, @gmcrocetti. If you want, please add yourself to the AUTHORS file!
Oh, thanks for that ! :) |
@gmcrocetti - Last-minute ask: could you squash your commits before I merge? Sorry for the hassle! |
…e client's behavior into pydantic's models feat(setup): Add pydantic as extra package and update pipenv
29d2f4c
to
07edb49
Compare
No problem. Should be fixed. |
Does this PR adds support for GenericModel? |
Fixes #146 .
Changes proposed in this pull request:
This PR introduces pydantic as one of the available models. I'd like to hear your opinion before proceeding with docs.
Attention: @prkumar