-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Kernel DSL) Revert esc change toplevel, include GlobalRef to handle evaluation ambiguity in modules/submodules. #463
Conversation
…biguity in modules/submodules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just suggested a few style changes for greater readability!
…biguity in modules/submodules.
…biguity in modules/submodules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a minor comment about whether to make the GlobalRefs const
, since they are global variables now. Fine either way though!
Oh, the other thing we should do is add a test case that makes sure the error you ran into earlier (of using a custom proposal) doesn't happen again! |
Re -- I'll address the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! For the test cases, maybe we should also test a kernel that uses a custom proposal, to ensure we don't reintroduce that bug again?
@ztangent I don't think the issue was using a custom proposal in Or, do you mean -- capturing the name of the proposal in the kernel at module scope? I can (and should) easily add the latter. |
Yup, this is what I meant! Because it's the issue that came up when we tried not-escaping everything. |
No description provided.