Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex-m usage is unclear #17

Closed
t-moe opened this issue Dec 27, 2023 · 1 comment
Closed

Cortex-m usage is unclear #17

t-moe opened this issue Dec 27, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@t-moe
Copy link
Contributor

t-moe commented Dec 27, 2023

The readme:

  • suggests that the patched panic_probe is optional for cortex-m. (hardfaults do not seem to fail the test, only semihosting...)
  • does not mention that you have to patch all defmt crates, until risc-v support for defmt-test knurling-rs/defmt#796 is merged and released.
  • does not mention that you need to provide the exception handlers yourself. Previously panic-probe did that.
@t-moe t-moe added the documentation Improvements or additions to documentation label Dec 27, 2023
@t-moe
Copy link
Contributor Author

t-moe commented Jan 9, 2024

This should be more clear now, I've updated the readme, and the cargo.toml files here and in the example repo

@t-moe t-moe closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant