Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risc-v support for defmt-test #796

Closed
wants to merge 5 commits into from

Conversation

t-moe
Copy link
Contributor

@t-moe t-moe commented Nov 15, 2023

This PR adds riscv32 support to defmt-test and panic-probe. Additionally it adds the print-log feature to panic-probe.

In a separate PR I will:

  • Update the app-template, to include use cortex_m_rt as _; (as it is no longer included in defmt-test)

@t-moe
Copy link
Contributor Author

t-moe commented Nov 24, 2023

Hei @japaric or @Urhengulas
Can you look at this draft?

I've removed the udf instruction to trigger a hard fault and instead use semihosting.
(To my knowledge, riscv has no such thing as an udf instruction, to manually trigger a hardfault.)
That way we can get support for riscv and later a lot more platforms (see https://github.com/taiki-e/semihosting#platform-support).

@BriocheBerlin
Copy link
Contributor

Sorry this is taking so long. Unfortunately we can't look at this before the week of December 11.

@jonathanpallant
Copy link
Contributor

jonathanpallant commented Dec 15, 2023

Hi! Sorry for the delay. The draft looks good in principle - just a few comments.

There are some some CI failures to look at - a loop that doesn't loop, and a changelog update that isn't in the right format.

@t-moe t-moe marked this pull request as ready for review December 27, 2023 18:52
@Urhengulas Urhengulas added the breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version label Mar 6, 2024
@SergioGasquez
Copy link

Hi! What is the status on this PR?

@t-moe
Copy link
Contributor Author

t-moe commented Mar 6, 2024

@SergioGasquez
I'll probably abandon this, as I have created embedded-test now which is much more under our control. Also I feel that the testing framework shouldn't be coupled to whether you use defmt or not.

I'll also create panic_semihosting_abort which does what I tried to do in this PR with panic_probe.

@t-moe
Copy link
Contributor Author

t-moe commented May 29, 2024

Abandoning this, as I want to focus on embedded-test (which is now part of probe-rs)

@t-moe t-moe closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants