-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appimagetool don't configure loaders.cache
#284
Comments
Hello @brunvonlope, apparently you know a lot about the inner workings of GTK (well, at least compared to me, anyways). Would you be able to send a pull request? Thanks for your suggestion. |
I know almost nothing, specially about Go |
We already have some code related to it: go-appimage/src/appimagetool/appdirtool.go Lines 625 to 675 in 6866993
Maybe it is not working properly? |
Indeed it's not working:
My system doesn't even have a This could either be fixed by assuming the following directory layout
so that the loaders can be found from the location of |
Thanks @pbs3141. I'd appreciate code contributions from someone knowledgeable about Gtk here. Has https://github.com/linuxdeploy/linuxdeploy-plugin-gtk/blob/3b67a1d1c1b0c8268f57f2bce40fe2d33d409cea/linuxdeploy-plugin-gtk.sh#L312-L332 the correct logic? |
The patching of loaders.cache to remove absolute paths had stopped working due libpixbufloader-png.so no longer being present. Fix it by calculating the path to patch out a different way. probonopd#284
The patching of loaders.cache to remove absolute paths had stopped working due libpixbufloader-png.so no longer being present. Fix it by calculating the path to patch out a different way. #284
Similar to #282
When bundling GTK apps, appimagetool copy the loaders.cache file required by GdkPixbuf. But inside the file the paths aren't adapted to be relative to AppDir/usr/lib... which makes the system loaders be called by GdkPixbuf.
I suggest changing the paths inside the loaders.cache file when calling
deploy
in a similar way that we do manually with GIMP: https://gitlab.gnome.org/GNOME/gimp/-/blob/master/build/linux/appimage/bundle-gimp-appimage.sh?ref_type=heads#L170. Otherwise, some apps can even not display the GUI at all.The text was updated successfully, but these errors were encountered: