Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization #249

Closed
wants to merge 12 commits into from
Closed

Reorganization #249

wants to merge 12 commits into from

Conversation

CalebQ42
Copy link
Contributor

This is mostly some re-organization and cleanup loosely similar to #234

  • Moved files to be under cmd (mkappimage, appimagetool, appimaged) and pkg (goappimage) instead of everything under src.
  • A bunch of cleanup suggested by linters.

And a couple features for appimaged:

  • Removed notification about not running on a supported system. appimaged seems to be in a fairly stable spot and should work on most distros and it mainly seems to cause confusion.
    • Happy to re-add this is you feel it's still necessary.
  • Instead of detecting if it's running in systemd move via an environment variable, it's now a separate launch command.
  • Re-formatted the usage function (--help)
  • Added flag to disable the mqtt service.
    • I've seen a few complaints about this, so now it can be disabled.
  • Fixed the quiet flag not doing anything.
  • When installing to systemd, flags you use when launching appimaged is now added to the sytemd service.
  • Allows for the flags to be actually useful.
  • Fixes issues such as Need a way to disable all desktop notifications #178

@probonopd
Copy link
Owner

Thanks a lot @CalebQ42. As a general rule, I'd like to avoid configurability in appimaged when possible; ideally it should "just work" for everyone in the same way.

But since so many people have reported issues with the current state of MQTT (and it is experiemental, as is the rest of the tools) I think we should disable it for now by default and only use it if explicitl requested by the user.

@CalebQ42
Copy link
Contributor Author

I think having a couple options that don't change the actual functionality could be useful. In particular, in #178 it's mentioned that disabling desktop notifications would be very nice to have. In that issue it was mentioned to check for the existence of a file (~/.config/appimaged/no_desktop_notifications), but a flag was already in the code so I went ahead and just hooked that up.

For the MQTT update service, I agree that it would probably be best to default it to disabled until it get some work, but it's probably best to keep it available to allow for easier testing. In these cases, would you prefer to pass-through the flags used when installing the service or simply leave it and if someone really wants to use the flags then they'll have to manually edit the service file themselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants