Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Fix the package renaming in the R-CMD-check workflow #182

Merged
merged 1 commit into from
Jan 9, 2023
Merged

[INFRA] Fix the package renaming in the R-CMD-check workflow #182

merged 1 commit into from
Jan 9, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jan 9, 2023 •
edited
Loading

Some configuration changes were forgotten in the workflow at the time of the name change (from bpmnVisualization to bpmnVisualizationR).

Before

image

Now

image

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jan 9, 2023
@csouchet csouchet marked this pull request as ready for review January 9, 2023 16:00
tbouffard
tbouffard approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
✔️ no more warnings. Previously we saw:

image

✔️ artifacts are now available

image

@csouchet csouchet merged commit 49b1035 into main Jan 9, 2023
@csouchet csouchet deleted the fix_renaming_in_R-CMD-check_workflow branch January 9, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard