Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Remove the patch of the bpmn-visualization package.json when version 0.39.0 is available #97

Closed
3 tasks done
tbouffard opened this issue Aug 30, 2023 · 0 comments · Fixed by #109
Closed
3 tasks done

[INFRA] Remove the patch of the bpmn-visualization package.json when version 0.39.0 is available #97

tbouffard opened this issue Aug 30, 2023 · 0 comments · Fixed by #109
Assignees
@tbouffard
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Milestone
0.4.0

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 30, 2023 •
edited
Loading

This patch has been configured to make jest tests work. See #100.
bpmn-visualization will be fixed once process-analytics/bpmn-visualization-js#2840 has been merged and released.

Tasks
Beta Give feedback
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 30, 2023
@tbouffard tbouffard added this to the 0.4.0 milestone Aug 30, 2023
@tbouffard tbouffard self-assigned this Sep 4, 2023
@tbouffard tbouffard mentioned this issue Sep 4, 2023
Merged
tbouffard added a commit that referenced this issue Sep 4, 2023
@tbouffard
chore: use bpmn-visualization 0.39.0 as peer dependency (#109)
3386dce 
Versions of `bpmn-visualization` prior to 0.39.0 did not support ESM in
Node.js projects. They required the package.json file of
`bpmn-visualization` to be patched in order to run tests.
`[email protected]` fixes this problem, so the patch can be
removed.

closes #97
relates to #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbouffard tbouffard

Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
0.4.0
1 participant
@tbouffard