Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on contributor page readme #448

Closed
wants to merge 6 commits into from

Conversation

sambensim
Copy link

  • Fixed 6 links as outlined in Issue Broken Links #444.

  • Additionally fixed a typo in the second to last paragraph (changed from "there are many more ways to contribute to p5.js through non-source code contribution than can be exhaustively listed here" to "there are many more ways to contribute to p5.js through non-source code contribution than cannot be exhaustively listed here").

- Fixed 6 links as outlined in Issue processing#444.
- Additionally fixed a typo in the second to last paragraph (changed from "there are many more ways to contribute to p5.js through non-source code contribution than can be exhaustively listed here" to "there are many more ways to contribute to p5.js through non-source code contribution than ***cannot*** be exhaustively listed here")
@sambensim
Copy link
Author

@all-contributors please add @sambensim for 📖 doc

Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple fixes in the line comments.

src/content/contributor-docs/en/README.mdx Outdated Show resolved Hide resolved
src/content/contributor-docs/en/README.mdx Outdated Show resolved Hide resolved
@SableRaf
Copy link

@sambensim would you mind revising this PR to focus only on the fixes to the broken links?

Feel free to open a separate issue for the copy. Though it is not a typo, the text could be made clearer (see my inline comment).

@sambensim
Copy link
Author

@sambensim would you mind revising this PR to focus only on the fixes to the broken links?

Feel free to open a separate issue for the copy. Though it is not a typo, the text could be made clearer (see my inline comment).

Hey! Sorry just saw this, should I use the text you suggested earlier or just focus on the link fixes?

@SableRaf
Copy link

@sambensim No worries! Thanks for your reply :) I'd suggest focusing on the links.

If you want to address the text please open a separate issue. It is correct as is but your intuition to correct it shows that the phrasing could be clearer.

@Qianqianye
Copy link
Collaborator

Thanks @sambensim for all your work on this. The contribute pages on p5js.org website are built directly from p5.js library repo contributor_docs folder. So if we want to make changes, we will edit the docs in p5.js library repo contributor_docs folder,

All the broken links mentioned in this PR is fixed in this commit in p5.js library repo, and then this commit in p5.js website repo. In the future, if you find more broken links of contribute pages, please go ahead and open PRs within p5.js library repo.

I will close this PR for organizational purpose. Thank you!

@Qianqianye Qianqianye closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants