Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inline code rendering issue in curveVertex #481

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

DenisovichDev
Copy link
Contributor

Hello, this is my first PR here!

I noticed some inline code issues that might have popped up because of some porting issues from the old website. This is what it looked like:
image

Here's what it looks like now:
image

These were some special cases in the reference where it wasn't a code snippet but a multiline inline codes.

This fixes some porting issues with the page from the old website
@davepagurek
Copy link
Collaborator

Thanks @DenisovichDev! The reference gets updated every release from the contents in the p5.js repo, so I think we'll need to update the source there to not get turned back into multiple lines. I fixed a similar issue in the p5.js repo here https://github.com/processing/p5.js/pull/7089/files, does that method also apply to these functions?

Within this repo, I think rather than having inline code blocks separated by newlines, we might want to just group everything into one code block. That ends up looking like this: https://github.com/processing/p5.js-website/pull/407/files#diff-a9f22d63312d5dcf8286875d13c5ca83ee171d6bb92a2a21b8c50b7090771010R55

@DenisovichDev
Copy link
Contributor Author

DenisovichDev commented Aug 14, 2024

Thanks for the reply! I suppose that would fix it. So, shall I make a pull request changing the docstring in the p5.js repo?

And for this repo, I'll make the changes that you mentioned then, by grouping it with the <pre> tags

@davepagurek
Copy link
Collaborator

Sounds good, thanks so much!

@DenisovichDev
Copy link
Contributor Author

While editing the reference from p5.js repo I noticed a similar issue in normal() as well, so I have made the changes and added it here

Copy link
Collaborator

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes @DenisovichDev!

@davepagurek davepagurek merged commit 586b3dd into processing:main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants