[fix] Reimplemented dom.createRadio and added unit tests #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenilgandhi
changed the title
fenilgandhi
changed the title
|
I was trying something out but it doesn't work. Will have to wait until #4409 gets merged. |
|
@fenilgandhi can you resolve conflicts on this one too? and let me know if there is a preferred order I should merge your open PRs. |
- Re-implemented createRadio method - Added missing methods to createRadio like remove, disable - Added tests for createRadio - Updated documentation to match implementation
fenilgandhi
changed the title
|
thanks! |
17 tasks
nanselmo
added a commit
to nanselmo/p5.js
that referenced
this pull request
Jan 20, 2022
Updating example and documentation related to processing#4948. The label and the value parameters are swapped in the latest implementation of radio() (processing#4430)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #4425
Changes:
Screenshots of the change:
PR Checklist
npm run lintpasses