Allow drawing point with large scale and small strokeWeight. #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 19, 2020 00:48
Remove a Math.round and a conditional statement from p5.Renderer2D.point function because a point is not rendered as intended when large scale and small strokeWeight set.
This change of the conditional is needed to allow drawing points with a radius below 1px, and it is enough to check the point is entirely black when it failed to reset the rendering matrix.
Remove a Math.round and a conditional statement from p5.Renderer2D.point function because a point is not rendered as intended when large scale and small strokeWeight set.
This change of the conditional is needed to allow drawing points with a radius below 1px, and it is enough to check the point is entirely black when it failed to reset the rendering matrix.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
1 task
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4707 Shape point() does not work with scale > 1, strokeWeight < 1
Changes:
PR Checklist
npm run lintpasses